Update Poland holidays: fix Ascension Day (#1751)

Co-authored-by: Arkadii Yakovets <[email protected]>
vacanza · Apr 3, 2024 · 3171304 · 3171304
1 parent b09e276
commit 3171304
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/holidays/countries/poland.py b/holidays/countries/poland.py
@@ -10,7 +10,6 @@
 #  Website: https://github.com/vacanza/python-holidays
 #  License: MIT (see LICENSE file)
 
-from datetime import timedelta as td
 from gettext import gettext as tr
 
 from holidays.calendars.gregorian import NOV
@@ -68,7 +67,7 @@ def _populate_public_holidays(self):
 
         if self._year <= 1950:
             # Ascension Day.
-            self._add_holiday(tr("Wniebowstąpienie Pańskie"), self._easter_sunday + td(days=+40))
+            self._add_ascension_thursday(tr("Wniebowstąpienie Pańskie"))
 
         # Pentecost.
         self._add_whit_sunday(tr("Zielone Świątki"))

diff --git a/snapshots/countries/PL_COMMON.json b/snapshots/countries/PL_COMMON.json
@@ -7,7 +7,7 @@
     "1950-05-01": "National Day",
     "1950-05-03": "National Day of the Third of May",
     "1950-05-09": "National Victory and Freedom Day",
-    "1950-05-19": "Ascension Day",
+    "1950-05-18": "Ascension Day",
     "1950-05-28": "Pentecost",
     "1950-05-29": "Whit Monday",
     "1950-06-08": "Corpus Christi",

diff --git a/tests/countries/test_poland.py b/tests/countries/test_poland.py
@@ -138,19 +138,21 @@ def test_swieto_narodowe_trzeciego_maja(self):
 
     def test_narodowe_swieto_zwyciestwa_i_wolnosci(self):
         self.assertHoliday(f"{year}-05-09" for year in range(1946, 1951))
-        self.assertNoHoliday(f"{year}-05-09" for year in range(1925, 1946))
+        self.assertNoHoliday(
+            f"{year}-05-09" for year in set(range(1925, 1946)).difference({1929})
+        )  # Exclude Ascension day on 09/05/1929
         self.assertNoHoliday(f"{year}-05-09" for year in range(1951, 2050))
         self.assertNoHolidayName(
             "Narodowe Święto Zwycięstwa i Wolności", range(1925, 1946), range(1951, 2050)
         )
 
     def test_wniebowstapienie_panskie(self):
         self.assertHoliday(
-            "1930-05-30",
-            "1934-05-11",
-            "1939-05-19",
-            "1945-05-11",
-            "1950-05-19",
+            "1930-05-29",
+            "1934-05-10",
+            "1939-05-18",
+            "1945-05-10",
+            "1950-05-18",
         )
         self.assertNoHolidayName("Wniebowstąpienie Pańskie", range(1951, 2050))