Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XNYS holidays: standardize US market holidays days of mourning entries #2213

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Refactor XNYS holidays: standardize US market holidays days of mourning entries #2213

merged 8 commits into from
Jan 6, 2025

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Jan 5, 2025 •
edited
Loading

Proposed change

  • Standardize US market holidays' days of mourning entries for presidents based on Libracry of Congress sources.
  • Refractor to simplify down NYSE test cases whenever possible.

Resolves #2203 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (512ad34) to head (4263746).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11818     11828   +10     
  Branches      1707      1707           
=========================================
+ Hits         11818     11828   +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico
Copy link
Collaborator

McKinley, Harding and Kennedy died while being presidents. I don't think we should use "former" for them.

@KJhellico KJhellico changed the title Refractor NYSE holidays: standardize US market holidays' days of mourning entries Refactor XNYS holidays: standardize US market holidays' days of mourning entries Jan 5, 2025
@arkid15r
Copy link
Collaborator

arkid15r commented Jan 6, 2025

McKinley, Harding and Kennedy died while being presidents. I don't think we should use "former" for them.

This one is tricky. They are former now for sure... From what I read only the current one is the President (even though the press has different perspective). I wish we had a native English speaker help here.

PPsyrius and others added 2 commits January 6, 2025 09:29
@PPsyrius @KJhellico
[XNYS] typo fixed
4f9ab38 
Co-authored-by: ~Jhellico <[email protected]>
Signed-off-by: Panpakorn Siripanich <[email protected]>
@PPsyrius
[XNYS] update testcase and snapshot
340f438
@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Jan 6, 2025

@KJhellico @arkid15r After looking up, Presidents who died during their tenure doesn't have "former" in the proclamation name as you've said i.e. JFK's vs Reagan's.

I'll update the changes accordingly then 🙏

arkid15r
arkid15r reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PPsyrius thanks for cleaning this up!

Could you add NewYorkStockExchangeStaticHolidays docstring with the LoC link?

@PPsyrius PPsyrius requested review from arkid15r and KJhellico January 6, 2025 08:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arkid15r arkid15r enabled auto-merge January 6, 2025 18:16
arkid15r
arkid15r approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Jan 6, 2025
Merged via the queue into vacanza:dev with commit c2b4dca Jan 6, 2025
31 checks passed
@arkid15r arkid15r changed the title Refactor XNYS holidays: standardize US market holidays' days of mourning entries Refactor XNYS holidays: standardize US market holidays days of mourning entries Jan 6, 2025
@arkid15r arkid15r mentioned this pull request Jan 6, 2025
Merged
@PPsyrius PPsyrius deleted the NYSE-pres branch January 7, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees
No one assigned
Labels
snapshot test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize US market holidays' days of mourning entries
3 participants
@PPsyrius @KJhellico @arkid15r