Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README links targets #1677

Closed
arkid15r opened this issue Jan 29, 2024 · 2 comments
Closed

Fix README links targets #1677

arkid15r opened this issue Jan 29, 2024 · 2 comments
Assignees

Comments

@arkid15r
Copy link
Collaborator

Some of the README.rst's Contributions and License section links looks right on Github but result in 404 on PYPI and RTD platforms. We need to fix it so links would work right everywhere.

@nwithan8
Copy link
Contributor

Working fine for me from PyPi: https://pypi.org/project/holidays/

They're absolute URLs, so shouldn't be a problem.

@arkid15r arkid15r self-assigned this Apr 15, 2024
@arkid15r
Copy link
Collaborator Author

That's right, the issue has been resolved in #1745

Thanks for verifying this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants