Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute for classifying requests to root spans #66

Open
sissbruecker opened this issue Aug 26, 2022 · 0 comments
Open

Add attribute for classifying requests to root spans #66

sissbruecker opened this issue Aug 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sissbruecker
Copy link
Collaborator

Currently request handler instrumentations add spans for their execution, and some of them change the root span name. Depending on the used monitoring software, both can be kind of hard to search for if you are interested in all requests of a specific type.

In order to classify types of requests it would be useful to have an attribute on the root span that could be filtered by. This attribute could be set by individual request handler instrumentations, if they determine that the request was actually handled by the handler. This could either be a vaadin.request.handler which could contain the request handler class name, or a more abstract vaadin.request.type which contains a classification of the request, for example rpc, static, stream-resource.

@heruan heruan added the enhancement New feature or request label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants