Add configuration for different instrumentation levels #62
Labels
enhancement
New feature or request
Comments
caalador
pushed a commit
that referenced
this issue
Aug 30, 2022
Allows to configure a global trace level option that instrumentations can check for whether they should add some detail to a trace or not. The option supports three levels `minimum`, `default`, `maximum`. The default is `default`. The option can be changed using any of the configuration mechanism supported by OpenTelemetry, for example environment variables or system properties. For example, to change the trace level with a system property, add the following argument to the java process: `-Dotel.instrumentation.vaadin.trace-level=maximum`. This PR is only intended to add the basic option mechanism, and adapts the `UidlRequestHandlerInstrumentation` to demonstrate its use. The remaining instrumentations will be changed in a separate PR. Part of #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have properties for controlling what instumentation is used.
One property to consider could be
vaadin.instrumentation.levelwith the levels oftrace,detailedandinfowhere trace would make spans for all the things, detailed for all rpc requests and info more of an overview.Some true/false properties could be
vaadin.instrumentation.request.handler,vaadin.instrumentation.rpc.sync,vaadin.instrumentation.rpc.server.event. Disabling some of these should still not make the traces bad, just collect less details.All properties added need to add documentation in the PR.
The text was updated successfully, but these errors were encountered: