Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard property changed events for initial values #53

Open
sissbruecker opened this issue Aug 24, 2022 · 0 comments
Open

Disregard property changed events for initial values #53

sissbruecker opened this issue Aug 24, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sissbruecker
Copy link
Collaborator

Lots of Vaadin components dispatch property change events even for initial values. That is due to how Polymer works, which triggers property changed events even if the property has not been set before. This has the effect that showing a large form in its initial state will already add a lot of event spans, even if the user did not interact with the form yet.

We should look into whether we can skip creating these event spans if they refer to setting the initial property value. That might be possible by comparing the value of the event with the value of Element.getProperty.

This should cover at least value-changed events, but we can also try to cover other events like opened-changed.

@MatthewVaadin MatthewVaadin self-assigned this Sep 5, 2022
@heruan heruan added the enhancement New feature or request label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants