Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a single module for Flow and Hilla starters #248

Open
heruan opened this issue Feb 21, 2024 · 0 comments
Open

Consider a single module for Flow and Hilla starters #248

heruan opened this issue Feb 21, 2024 · 0 comments

Comments

@heruan
Copy link
Member

heruan commented Feb 21, 2024

With #247 the Flow and Hilla starters now share the same Maven com.vaadin group and contain overlapping classes.

Initially the idea of having Flow and Hilla starters as a single module was discarded to enforce product identity separation between Vaadin and Hilla and have the Hilla modules within the dev.hilla group.

Now that very premise has been overturned and we might consider again merging the two starters into a single module, e.g. using optional dependencies of Flow and Hilla and load the related classes on need.

This would simplify the adoption of the kit with a single com.vaadin:observability-kit-starter module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant