Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for V14 #143

Closed
heruan opened this issue Dec 9, 2022 · 7 comments
Closed

Support for V14 #143

heruan opened this issue Dec 9, 2022 · 7 comments
Labels

Comments

@heruan
Copy link
Member

heruan commented Dec 9, 2022

This issue tracks the progress of adding support to Observability Kit for Vaadin Platform V14.

@heruan heruan added the Epic label Dec 9, 2022
@MatthewVaadin
Copy link
Collaborator

PROBLEM: The HttpStatusCode class is not part of V14 and is used several times within the Kit code and tests.

SOLUTION: Replace with HttpServletResponse constants.

@MatthewVaadin
Copy link
Collaborator

MatthewVaadin commented Dec 9, 2022

PROBLEM: The ApplicationConstants.REQUEST_LOCATION_PARAMETER constant is not part of V14 and is used in JavaScriptBootstrapHandlerInstrumentation and its test.

SOLUTION: Add the value "location" as a constant of the kit class Constants and replace the the usages.

@MatthewVaadin
Copy link
Collaborator

PROBLEM: The MockVaadinService class used in the tests does not implement the correct method signatures for V14.

SOLUTION: Implement the correct method signatures (as well as retaining the V23 signatures).

@MatthewVaadin
Copy link
Collaborator

PROBLEM: When testing against V14, there is an exception saying that the push mode cannot be null.

SOLUTION: In the MockVaadinService, mock DeploymentConfiguration.getPushMode() to return PushMode.DISABLED.

@MatthewVaadin
Copy link
Collaborator

MatthewVaadin commented Dec 9, 2022

PROBLEM: When testing against V14, the AbstractInstrumentationTest class does not compile. The number of arguments for mockUI.getInternals().showRouteTarget() is incorrect.

SOLUTION: Add a new path argument with value "/test-route".

NOTE: This will cause a compilation error when compiling against V23, so a more permanent solution may be required.

@MatthewVaadin
Copy link
Collaborator

PROBLEM: The V14 version of the bakery app does not output any traces.

NO SOLUTION

NOTE: According to some debug output on the SessionRequestHandlerInstrumentation class, the instrumentation hooks are being called (classLoaderOptimization(), typeMatcher(), and transform()), but the onMethodEnter() and onMethodExit() methods are not. Need to investigate further as to why this is.

@heruan
Copy link
Member Author

heruan commented Feb 21, 2023

Delivered in #145

@heruan heruan closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants