Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when trying to create V10 design in V8 project #1788

Closed
szolo opened this issue May 24, 2018 · 5 comments
Closed

Exception when trying to create V10 design in V8 project #1788

szolo opened this issue May 24, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@szolo
Copy link
Contributor

szolo commented May 24, 2018

Steps to reproduce

  1. Open V8 project.
  2. Try to create V10 design.

Actual behavior

pic

java.lang.NullPointerException
	at com.vaadin.designer2.services.flow.webjar.WebjarUtil.cleanupWebjarImport(WebjarUtil.java:198)
	at com.vaadin.designer2.eclipse.wizards.NewFlowWizardPage.calculateProjectFromPath(NewFlowWizardPage.java:148)
	at com.vaadin.designer2.eclipse.wizards.NewFlowWizardPage.<init>(NewFlowWizardPage.java:103)
	at com.vaadin.designer2.eclipse.wizards.NewFlowWizard.addPages(NewFlowWizard.java:61)

Expected behavior

Hide exception. In IntelliJ if you select V10 design wizard says later that Polymer dependencies are missing. Same behavior should be present in Eclipse.

IDE, Designer and OS version

Windows 10, Eclipse Oxygen , Designer 3.0.2

@ripla
Copy link
Contributor

ripla commented May 24, 2018

I think we should hide the option to create V10 designs in V8 projects. Is that possible?

@szolo
Copy link
Contributor Author

szolo commented May 25, 2018

@ripla sure, I think it's possible. We need to do it in IntelliJ as well.

@szolo szolo added the IntelliJ label May 25, 2018
@ripla
Copy link
Contributor

ripla commented May 28, 2018

This could be reproducible in V10 projects as well. Maybe a malformed project?

@szolo
Copy link
Contributor Author

szolo commented May 28, 2018

@ripla needs to be checked, after project import dependencies should be available with Eclipse API.

@ripla ripla added the backlog label May 29, 2018
@ripla
Copy link
Contributor

ripla commented May 30, 2018

It should be possible to create designs in any kind of project. If it's not possible due to a technical limitation, show a message.

@ripla ripla removed the IntelliJ label May 30, 2018
@tanbt tanbt self-assigned this Jun 11, 2018
@tanbt tanbt closed this as completed Jun 12, 2018
@tanbt tanbt reopened this Jun 12, 2018
@ripla ripla added this to the 3.0.4 milestone Jun 20, 2018
@ripla ripla closed this as completed Jun 20, 2018
@ripla ripla removed the backlog label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants