Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer doesn't update element reference id in Java companion when changing id (but adds a new reference) #1604

Closed
stefanuebe opened this issue Mar 8, 2018 · 0 comments
Assignees
Milestone

Comments

@stefanuebe
Copy link

Steps to reproduce

  1. Create a flow template with a Java companion
  2. Insert an element (like div).
  3. Assign an id "x1".
  4. Mark Java checkbox for this element.
  5. Change the id to "x2".
  6. Mark Java checkbox for this element again.
  7. Start application.

Actual behavior

Designer adds two references for "x1" and "x2". This leads to an error message since "x1" can not be resolved anymore.

Expected behavior

Old reference should be removed if it can be found unambiguously (i.e. no other element with the same old id is found for this template).

If the old reference does not meet the default template for such an reference there could be an confirmation dialog like "We found something with the old id but it seems to be an element of another type. Remove anyway?"

Alternative expected behaviour

If automatic deletion is not possible or not wished, then there should occur a hint like "Added reference with new id for this element. Remember to delete the old reference".

IDE, Designer and OS version

IntelliJ 2017.3.4, Designer 3.0.0 beta2, Windows 10

@stefanuebe stefanuebe changed the title Designer doesn't update related element in Java companion when changing id but adding a new reference Designer doesn't update element reference id in Java companion when changing id (but adds a new reference) Mar 8, 2018
@ripla ripla added the flow label May 3, 2018
@ripla ripla added backlog and removed Needs UX labels May 16, 2018
@anssit anssit self-assigned this May 23, 2018
@tanbt tanbt self-assigned this May 28, 2018
@szolo szolo self-assigned this Jun 4, 2018
@ripla ripla removed the backlog label Jun 5, 2018
@ripla ripla added this to the 3.0.3 milestone Jun 7, 2018
@ripla ripla closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants