Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery sources from repo #537

Closed
alvarezguille opened this issue Sep 7, 2018 · 1 comment
Closed

Remove jquery sources from repo #537

alvarezguille opened this issue Sep 7, 2018 · 1 comment
Assignees

Comments

@alvarezguille
Copy link
Member

there is a deprecated @source for jquery
@Source("jquery.min.js") @Deprecated TextResource jquery();
but the resource loading doesn't use it, it just checks for jquery and loads highcharts standalone framework
if (!hasJQuery()) { inject(HighchartResources.INSTANCE.standaloneframework().getText()); }
We should still remove it since having it there might trigger some security scanners and cause uncertainty
Change should be done for charts 3 and 4

@alvarezguille
Copy link
Member Author

This issue was fixed in #540 and #539 and will be released in Charts 3.3 and 4.1.
As I mentioned before the source was deprecated and sent to client but not used except in the serverside SVG generator.
Not it will be not included nor referenced in both client and server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants