Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin Charts 3.0.0 has 'split-packages' and therefore problems for OSGi deployment #327

Closed
vaadin-bot opened this issue May 15, 2016 · 3 comments
Labels

Comments

@vaadin-bot
Copy link
Collaborator

Originally by djmcgreal


com.vaadin.addon.charts.model is in both the vaadin-charts-model and vaadin-charts bundles.
vaadin-charts-model has no OSGi headers.
Also, since vaadin-charts both imports and exports com.vaadin.addon.charts.model and com.vaadin.addon.charts.model.styles there's quite some difficulty getting these to resolve well.

I suggest resolving the split package somehow and updating the maven-bundle-plugin's configuration in vaadin-charts and adding it to vaadin-charts-model.


Imported from https://dev.vaadin.com/ issue #19815

@vaadin-bot
Copy link
Collaborator Author

Originally by djmcgreal


com/vaadin/addon/charts/util is also duplicated

@vaadin-bot
Copy link
Collaborator Author

Originally by rasikapethe


Hi,

Also wanted to add for this ticket.
vaadin-charts / vaadin-charts-model as well as vaadin-charts / vaadin-server host split packages (com.vaadin.ui, com.vaadin.addon.charts.model). This makes it cumbersome to impossible to use the jars as OSGi bundles. Please resolve the split packages by either moving the complete package to one or the other jar.

@vaadin-bot vaadin-bot added the bug label Oct 17, 2016
@benstpierre
Copy link

This also means Vaadin-Charts does not work in Java 9.

When you try to use Vaadin-Charts in Java 9 you get this

[ERROR] module com.yourcompany.yourproject.module reads package com.vaadin.addon.charts.model from both vaadin.charts.model and vaadin.charts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants