Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing build statements #10

Open
martinandersson opened this issue May 12, 2021 · 3 comments
Open

Confusing build statements #10

martinandersson opened this issue May 12, 2021 · 3 comments

Comments

@martinandersson
Copy link

In the README, it is said that command ./gradlew -Pvaadin.productionMode "will build this app in production mode as a WAR archive". In the subsequent section, approximately the same thing ("To build your app for production") is stated about a different command ./gradlew clean build -Pvaadin.productionMode.

This needs to be clarified.

Ideally, we should also explain why we're adding the "clean" hack in the last command. Smells like the Vaadin Gradle plugin or a dependent feature of the build system isn't working properly, hence the "clean".

@caalador
Copy link
Contributor

Actually if you look at the default in build.gradle you can see that it is defined as defaultTasks("clean", "build") so running ./gradlew is the same as running ./gradlew clean build
This should probably be mentioned and the same format used for each case.

@martinandersson
Copy link
Author

lol so much magic everywhere. Don't you get tired of it yourself?

Also, thank you for your answer, of course! =) Still, curious to know why the clean-hack.

@caalador
Copy link
Contributor

For a production build using clean build is to get no development mode files in by mistake, but else it should be fine to not have clean.
I feel we should probably drop clean from the default tasks as it shouldn't be needed for each and every execution and was left there by mistake from the unofficial version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants