You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the README, it is said that command ./gradlew -Pvaadin.productionMode "will build this app in production mode as a WAR archive". In the subsequent section, approximately the same thing ("To build your app for production") is stated about a different command ./gradlew clean build -Pvaadin.productionMode.
This needs to be clarified.
Ideally, we should also explain why we're adding the "clean" hack in the last command. Smells like the Vaadin Gradle plugin or a dependent feature of the build system isn't working properly, hence the "clean".
The text was updated successfully, but these errors were encountered:
Actually if you look at the default in build.gradle you can see that it is defined as defaultTasks("clean", "build") so running ./gradlew is the same as running ./gradlew clean build
This should probably be mentioned and the same format used for each case.
For a production build using clean build is to get no development mode files in by mistake, but else it should be fine to not have clean.
I feel we should probably drop clean from the default tasks as it shouldn't be needed for each and every execution and was left there by mistake from the unofficial version.
In the README, it is said that command
./gradlew -Pvaadin.productionMode
"will build this app in production mode as a WAR archive". In the subsequent section, approximately the same thing ("To build your app for production") is stated about a different command./gradlew clean build -Pvaadin.productionMode
.This needs to be clarified.
Ideally, we should also explain why we're adding the "clean" hack in the last command. Smells like the Vaadin Gradle plugin or a dependent feature of the build system isn't working properly, hence the "clean".
The text was updated successfully, but these errors were encountered: