Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV64 Branch][HIFIVE Board] unittest/LoggingTest.SourceLocation failed #174

Closed
luyahan opened this issue Aug 20, 2020 · 2 comments · Fixed by #227
Closed

[RISCV64 Branch][HIFIVE Board] unittest/LoggingTest.SourceLocation failed #174

luyahan opened this issue Aug 20, 2020 · 2 comments · Fixed by #227
Assignees
Labels
bug Something isn't working

Comments

@luyahan
Copy link
Collaborator

luyahan commented Aug 20, 2020

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Build with options riscv64.native.debug
  2. Run test/program riscv64.native.debug/unittests --random-seed=-1603113582 --nohard-abort --enable-slow-asserts --verify-heap --testing-d8-test-runner --gtest_filter=LoggingTest.SourceLocation --gtest_random_seed=-1603113582 --gtest_print_time=0
  3. See error

Expected behavior
No error.

Errors/Logs

[ RUN      ] LoggingTest.SourceLocation
../../test/unittests/heap/cppgc/logging-unittest.cc:67: Failure
Death test: do { if ((__builtin_expect(!!(!(false)), 0))) { ::cppgc::internal::DCheckImpl("false"); } } while (false)
    Result: died but not with expected error.
  Expected: (has substring "../../test/unittests/heap/cppgc/logging-unittest.cc") and (has substring "69")
Actual msg:
[  DEATH   ]
[  DEATH   ]
[  DEATH   ] #
[  DEATH   ] # Fatal error in ../../test/unittests/heap/cppgc/logging-unittest.cc, line 67
[  DEATH   ] # Debug check failed: false.
[  DEATH   ] #
[  DEATH   ] #
[  DEATH   ] #
[  DEATH   ] #FailureMessage Object: 0x3fffd0b7e8
[  DEATH   ] ==== C stack trace ===============================
[  DEATH   ]
[  DEATH   ]     ./riscv64.native/unittests(+0x27022f0) [0x2ace51b2f0]
[  DEATH   ]     ./riscv64.native/unittests(+0x24ec33e) [0x2ace30533e]
[  DEATH   ]     ./riscv64.native/unittests(+0x24e0e46) [0x2ace2f9e46]
[  DEATH   ]     ./riscv64.native/unittests(+0x24e0e70) [0x2ace2f9e70]
[  DEATH   ]     ./riscv64.native/unittests(+0x2ac8b8) [0x2acc0c58b8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa3e36e) [0x2acc85736e]
[  DEATH   ]     ./riscv64.native/unittests(+0xa14cf6) [0x2acc82dcf6]
[  DEATH   ]     ./riscv64.native/unittests(+0xa15898) [0x2acc82e898]
[  DEATH   ]     ./riscv64.native/unittests(+0xa16cc8) [0x2acc82fcc8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa2f5a8) [0x2acc8485a8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa3e9b8) [0x2acc8579b8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa2c4a6) [0x2acc8454a6]
[  DEATH   ]     ./riscv64.native/unittests(+0x239d8a) [0x2acc052d8a]
[  DEATH   ]     /lib64/lp64d/libc.so.6(__libc_start_main+0xa6) [0x3fec712204]
[  DEATH   ]     ./riscv64.native/unittests(_start+0x2c) [0x2acc095c78]
[  DEATH   ]
../../test/unittests/heap/cppgc/logging-unittest.cc:70: Failure
Death test: do { if ((__builtin_expect(!!(!(false)), 0))) { ::cppgc::internal::FatalImpl("false"); } } while (false)
    Result: died but not with expected error.
  Expected: (has substring "../../test/unittests/heap/cppgc/logging-unittest.cc") and (has substring "72")
Actual msg:
[  DEATH   ]
[  DEATH   ]
[  DEATH   ] #
[  DEATH   ] # Fatal error in ../../test/unittests/heap/cppgc/logging-unittest.cc, line 70
[  DEATH   ] # Check failed: false.
[  DEATH   ] #
[  DEATH   ] #
[  DEATH   ] #
[  DEATH   ] #FailureMessage Object: 0x3fffaee7e8
[  DEATH   ] ==== C stack trace ===============================
[  DEATH   ]
[  DEATH   ]     ./riscv64.native/unittests(+0x27022f0) [0x2ad63b92f0]
[  DEATH   ]     ./riscv64.native/unittests(+0x24ec33e) [0x2ad61a333e]
[  DEATH   ]     ./riscv64.native/unittests(+0x24e0e46) [0x2ad6197e46]
[  DEATH   ]     ./riscv64.native/unittests(+0x15bde2e) [0x2ad5274e2e]
[  DEATH   ]     ./riscv64.native/unittests(+0x2ac8e8) [0x2ad3f638e8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa3e36e) [0x2ad46f536e]
[  DEATH   ]     ./riscv64.native/unittests(+0xa14cf6) [0x2ad46cbcf6]
[  DEATH   ]     ./riscv64.native/unittests(+0xa15898) [0x2ad46cc898]
[  DEATH   ]     ./riscv64.native/unittests(+0xa16cc8) [0x2ad46cdcc8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa2f5a8) [0x2ad46e65a8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa3e9b8) [0x2ad46f59b8]
[  DEATH   ]     ./riscv64.native/unittests(+0xa2c4a6) [0x2ad46e34a6]
[  DEATH   ]     ./riscv64.native/unittests(+0x239d8a) [0x2ad3ef0d8a]
[  DEATH   ]     /lib64/lp64d/libc.so.6(__libc_start_main+0xa6) [0x3fd05b9204]
[  DEATH   ]     ./riscv64.native/unittests(_start+0x2c) [0x2ad3f33c78]
[  DEATH   ]
[  FAILED  ] LoggingTest.SourceLocation (32413 ms)

Additional context
Add any other context about the problem here.

@luyahan luyahan added the bug Something isn't working label Aug 20, 2020
@luyahan luyahan added this to the native-build (09/04/2020) milestone Aug 20, 2020
@luyahan luyahan self-assigned this Aug 21, 2020
@luyahan
Copy link
Collaborator Author

luyahan commented Aug 21, 2020

On riscv64.sim, it pass. On hifive, it failed.
There is only a diff on line number. The expected line number is '69', the output is '67'
May it be caused by different compliers (gcc vs clang)?
@penguinwu If yes, can we ignore it ?

@penguinwu
Copy link

Yes, we can ignore this test case. Please add a comment on the status file.

@ghost ghost closed this as completed in #227 Sep 14, 2020
pull bot pushed a commit to Alan-love/v8 that referenced this issue Apr 24, 2021
This test produces different outputs when compiled with
gcc. It is currently failing on PPC using gcc-8, it also has
failed on riscv: riscv-collab#174

I have also tested it with gcc-10 on x64 and it still fails.
The line numbers seem to be different when compiled with gcc
instead of clang.

As a workaround we can force the usage of macros in one line
to assure outputs are the same on either compiler.

Change-Id: I36a05d0dc62dfe66bdfcf177422836cb231284b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844666
Reviewed-by: Anton Bikineev <[email protected]>
Commit-Queue: Milad Fa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#74162}
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants