Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better interface for T2I-Zero? #58

Open
drhead opened this issue Jul 8, 2024 · 0 comments
Open

better interface for T2I-Zero? #58

drhead opened this issue Jul 8, 2024 · 0 comments

Comments

@drhead
Copy link
Contributor

drhead commented Jul 8, 2024

From the small amount of experimentation I've done with T2I-Zero, it seems like it has a fair amount of potential, but right now it's really hard to use since I have to manually count tokens in the prompt and fix them every time I change the prompt.

I would think that the ideal method of control would be something that parses some part of the prompt as a marker like how sd-dynamic-prompts works (and this wouldn't be nearly as complex as that since this either has it applied to a token or not applied). There's possibly alternative ways to do it that might involve custom UI elements which may or may not be easier to implement (stable-diffusion-webui-tokenizer would be where I'd start for that).

edit: also somewhat related, I don't think there's any distinction between the positive and negative prompt, so t2i0 seems to always be applied to the negative prompt. This will also cause a device-side assert if the positive prompt is longer than the negative prompt and padding for the negative prompt is not enabled (this really needs to be replaced with cross attention masking on A1111's side so this isn't an issue, a lot of extensions have problems with this). Regardless of whether it crashes this does need some way of filtering the negative prompt out which may itself require forced unbatching of cond/uncond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant