Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README is confusing wrt ENV_FILE #44

Closed
slhck opened this issue Nov 24, 2022 · 7 comments
Closed

README is confusing wrt ENV_FILE #44

slhck opened this issue Nov 24, 2022 · 7 comments

Comments

@slhck
Copy link
Contributor

slhck commented Nov 24, 2022

The readme mentions:

If a .env.template file exists, this plugin refer it to create a environemnt variable properties in the env extension.

However, this appears not to work with the most recent version. Would it be possible to update the README to reflect the current behavior?

@uzzu
Copy link
Owner

uzzu commented Feb 15, 2023

@slhck

What's a most recent version of Gradle? Is it 8.0 or any other versions?

Please try this https://github.com/uzzu/dotenv-gradle/tree/main/examples/basic then if you have any questions, Please reopen this issue and comment. 🙏

@uzzu uzzu closed this as completed Feb 15, 2023
@slhck
Copy link
Contributor Author

slhck commented Feb 15, 2023

No, I meant your plugin's most recent version! It does not have that feature anymore but it is still mentioned in the documentation.

@slhck
Copy link
Contributor Author

slhck commented Feb 15, 2023

Or maybe I was mistaken, please ignore this issue for now. It appears the template function is still part of your plugin. When I posted this issue, it didn't work for me.

@uzzu
Copy link
Owner

uzzu commented Feb 15, 2023

@slhck
Thanks for clarifying.
I recognized that README is difficult.
The pull requests for the README are welcome, so if you have any suggestions, please let me know.

@slhck
Copy link
Contributor Author

slhck commented Mar 8, 2023

I now know what the problem is:

The README says:

Change a file to read instead of .env file.

If environment variable ENV_FILE is set, The plugin read a file specified ENV_FILE instead of .env file.

It links to an example, but there it says:

Please use dotenv.filename in gradle.properties instead of ENV_FILE.

So it seems like ENV_FILE no longer works?

@mkatrenik
Copy link

@slhck you can override gradle property through args
./gradlew test -P dotenv.filename=.env.local

@slhck
Copy link
Contributor Author

slhck commented Apr 28, 2023

@mkatrenik Yes, this is what it says in the example, and what I've quoted, but I wanted to point out that the readme is confusing and needs to be updated to not mention ENV_FILE if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants