Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bazel support #1434

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Conversation

Vertexwahn
Copy link
Contributor

This PR affects only the Bazel build support (CMake build stays untouched)

The following changes are introduced:

  • Update Bazel version (7.1.1 -> 7.2.1)
  • Update platforms from 0.0.9 to 0.0.10
  • Bazel tests: Bazilized a few more tests
  • Documentation: Add Bzlmod variant

@dnmokhov dnmokhov requested review from isaevil and aepanchi July 1, 2024 20:50
Copy link
Contributor

@aepanchi aepanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just small suggestions :)

Bazel.md Outdated Show resolved Hide resolved
Bazel.md Outdated Show resolved Hide resolved
Vertexwahn and others added 2 commits July 2, 2024 14:43
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
@isaevil
Copy link
Contributor

isaevil commented Jul 2, 2024

@Vertexwahn,
Thank you for your regular contributions to oneTBB project towards Bazel support! Due to your standing contributions I would like to ask whether you be comfortable/have a desire to be put in CODEOWNERS files as an owner of Bazel-related code?
If so I would kindly ask you to update https://github.com/oneapi-src/oneTBB/blob/master/CODEOWNERS accordingly in the scope of this patch :)

@Vertexwahn
Copy link
Contributor Author

@isaevil I added myself as a code owner for Bazel-related files

CI reports

Unknown owner on line 17: make sure @Vertexwahn exists and has write access to the repository
/oneTBB/.bazelversion @Vertexwahn

I think I have no write permission to the repo... not sure if this is necessary for only giving reviews...

Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isaevil isaevil merged commit 78d0290 into uxlfoundation:master Jul 3, 2024
22 checks passed
@isaevil
Copy link
Contributor

isaevil commented Jul 3, 2024

@isaevil I added myself as a code owner for Bazel-related files

CI reports

Unknown owner on line 17: make sure @Vertexwahn exists and has write access to the repository
/oneTBB/.bazelversion @Vertexwahn

I think I have no write permission to the repo... not sure if this is necessary for only giving reviews...

We'll figure this out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants