Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: misused variables from top level project #271

Closed
AlexVeprev opened this issue Aug 31, 2020 · 4 comments
Closed

CMake: misused variables from top level project #271

AlexVeprev opened this issue Aug 31, 2020 · 4 comments
Labels

Comments

@AlexVeprev
Copy link
Contributor

@arihannu found multiple CMake-related issues in scope of #207.
I'm moving them into separate issues for better tracking:

  • CMakeLists.txt#L190 and other install instructions: CMAKE_PROJECT_NAME should be replaced with PROJECT_NAME.
  • cmake/vars_utils.cmake#L25 and other instructions in this file: paths should be built based on CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR.
@AlexVeprev
Copy link
Contributor Author

@arihannu the issue should be addressed with a recent commit to master branch. Could you please check if it works for you?

@arihannu
Copy link

@AlexVeprev Hi, just tried master branch and CMake configuration and build passed without problems. Are you going to include these fixes into an official branch or should I just use master branch from now on?

@AlexVeprev
Copy link
Contributor Author

@arihannu, thank you for the verification! The fix should be available in onetbb_2021 with the next release (unfortunately I can't provide timeline for now). Generally the master branch should be updated more frequently than onetbb_2021. If you prefer to use official releases you can rely on onetbb_2021 and/or on tags v2021..., otherwise use master for the most recent sources.

@arihannu
Copy link

@AlexVeprev Then I think this issue can be closed. Thanks for the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants