Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df/uniq: suppress lint errors #3548

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

cakebaker
Copy link
Contributor

This PR is more of a workaround and suppresses a clippy lint error that was introduced with Rust 1.61.

I don't know how to fix this in a clean way because of some magic behavior of writeln! I couldn't figure out (it adds df: to the output when it's called the first time, but not in subsequent calls). This was also the reason I used eprintln!...

@sylvestre
Copy link
Contributor

maybe also

error: unnecessary structure name repetition
  --> src\uu\uniq\src/uniq.rs:37:6
   |
37 | enum Delimiters {
   |      ^^^^^^^^^^ help: use the applicable keyword: `Self`
   |
   = note: `-D clippy::use-self` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self

?

@cakebaker cakebaker changed the title df: suppress "print_in_format_impl" lint error df/uniq: suppress lint errors May 20, 2022
@cakebaker
Copy link
Contributor Author

With uniq it seems to be a false positive bug: rust-lang/rust-clippy#6902

@sylvestre sylvestre merged commit 9db0a87 into uutils:main May 20, 2022
@sylvestre
Copy link
Contributor

thanks

@cakebaker cakebaker deleted the suppress_clippy_error branch May 21, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants