From e9d6d80a097847641a680beeee49aaa14a7cbded Mon Sep 17 00:00:00 2001 From: Hunar Roop Kahlon Date: Sun, 20 Oct 2019 00:00:08 -0700 Subject: [PATCH 1/5] Introduce cargo fmt via Github Actions --- .github/workflows/fmt.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .github/workflows/fmt.yml diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml new file mode 100644 index 000000000..82693f81b --- /dev/null +++ b/.github/workflows/fmt.yml @@ -0,0 +1,24 @@ +name: Format Check + +on: [push, pull_request] + +jobs: + fmt: + name: Ubuntu Check + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v1 + - name: Install Toolchain + uses: actions-rs/toolchain@v1 + with: + profile: minimal + toolchain: 1.32.0 + override: true + - name: Install `rustfmt` + run: rustup component add rustfmt + - name: Run `cargo fmt` + uses: actions-rs/cargo@v1 + with: + command: fmt + args: --all -- --check From 9d82c0815593ce538ff19d45fedb0510fd3f72c6 Mon Sep 17 00:00:00 2001 From: Hunar Roop Kahlon Date: Sun, 20 Oct 2019 00:01:48 -0700 Subject: [PATCH 2/5] remove fmt step from travis --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 281f3c742..55d105371 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,7 +15,6 @@ matrix: - rustup component add rustfmt-preview - cargo install cargo-web script: - - cargo fmt --all -- --check - cargo test --features "serde std v1 v3 v4 v5" - cargo bench --features "serde std v1 v3 v4 v5" - cargo web build --features "v3 stdweb" @@ -54,7 +53,7 @@ matrix: - rust: 1.32.0 env: - LABEL="msrv" - script: +re script: - cargo test --features "serde std v4" notifications: From f9066d1ba28350ae5f048b307eb0c3ec697092a9 Mon Sep 17 00:00:00 2001 From: Hunar Roop Kahlon Date: Sun, 20 Oct 2019 00:09:29 -0700 Subject: [PATCH 3/5] remove unnecessary name --- .github/workflows/fmt.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml index 82693f81b..115083467 100644 --- a/.github/workflows/fmt.yml +++ b/.github/workflows/fmt.yml @@ -4,7 +4,6 @@ on: [push, pull_request] jobs: fmt: - name: Ubuntu Check runs-on: ubuntu-latest steps: - name: Checkout From 8d959e5e5f26bb5ecfc099fea1dae3495a4e7810 Mon Sep 17 00:00:00 2001 From: Hunar Roop Kahlon Date: Sun, 20 Oct 2019 00:14:13 -0700 Subject: [PATCH 4/5] merge rustfmt install step into the toolchain step --- .github/workflows/fmt.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml index 115083467..b0e151173 100644 --- a/.github/workflows/fmt.yml +++ b/.github/workflows/fmt.yml @@ -11,11 +11,10 @@ jobs: - name: Install Toolchain uses: actions-rs/toolchain@v1 with: + components: rustfmt + override: true profile: minimal toolchain: 1.32.0 - override: true - - name: Install `rustfmt` - run: rustup component add rustfmt - name: Run `cargo fmt` uses: actions-rs/cargo@v1 with: From 27b62e056ec4e18e6677f46444147bb6d0eb50a6 Mon Sep 17 00:00:00 2001 From: Hunar Roop Kahlon Date: Sun, 20 Oct 2019 00:24:15 -0700 Subject: [PATCH 5/5] fix unintentional random characters --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 55d105371..c41b4298f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,7 +53,7 @@ matrix: - rust: 1.32.0 env: - LABEL="msrv" -re script: + script: - cargo test --features "serde std v4" notifications: