Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export an ESM (ECMAScript Module) package for rgbpp-sdk #245

Closed
duanyytop opened this issue Jun 25, 2024 · 0 comments · Fixed by #246
Closed

Export an ESM (ECMAScript Module) package for rgbpp-sdk #245

duanyytop opened this issue Jun 25, 2024 · 0 comments · Fixed by #246
Assignees
Labels
enhancement New feature or request P-Low

Comments

@duanyytop
Copy link
Collaborator

duanyytop commented Jun 25, 2024

Now the rgbpp-sdk only exports CommonJS package, and it will cause a Named Exports issue when developers use ESM to import rgbpp-sdk like this:

"Named export 'Types' not found. The requested module 'mongoose' is a CommonJS module, which may not support all module.exports as named exports"

reference: https://stackoverflow.com/questions/70605320/named-export-types-not-found-the-requested-module-mongoose-is-a-commonjs-mo

To avoid potential issues, it is recommended to export an ESM package for rgbpp-sdk.

@duanyytop duanyytop added the enhancement New feature or request label Jun 25, 2024
@duanyytop duanyytop self-assigned this Jun 27, 2024
@Flouse Flouse linked a pull request Jun 27, 2024 that will close this issue
@Flouse Flouse added the P-Low label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants