Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled components not possible #24

Open
aidanhs opened this issue Jan 27, 2019 · 0 comments
Open

Controlled components not possible #24

aidanhs opened this issue Jan 27, 2019 · 0 comments

Comments

@aidanhs
Copy link

aidanhs commented Jan 27, 2019

See yewstack/yew#233 (comment) for context.

Essentially, the desired behavior is: if an edit for a field (e.g. an input or text area) is 'rejected' (i.e. not applied to the model), the render should not update. In react this is known as 'controlled components'.

In draco you can test this by applying the patch I've pasted at the bottom and then editing the username input element on the form example. Because the internal state isn't changing, arguably neither should the render. Unfortunately, it does.

React solves this by restoring state after a change event (described on the linked issue). Note that react also provides uncontrolled components where the value field is not set. I think the important thing is that both options are available (somehow).

diff --git a/examples/form.rs b/examples/form.rs
index b70b1d0..bb7c0a7 100644
--- a/examples/form.rs
+++ b/examples/form.rs
@@ -59,7 +59,7 @@ impl draco::App for Form {
                     .attr("id", "username")
                     .attr("name", "username")
                     .attr("value", self.username.clone())
-                    .on_input(Message::UpdateUsername),
+                    /*.on_input(Message::UpdateUsername)*/,
             )
             .push(
                 h::button()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant