Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I see that the global lru list "g_fcache_head" is not protected by locks, which may cause something wrong? #8

Open
melody97 opened this issue Aug 30, 2021 · 1 comment
Open

I see that the global lru list "g_fcache_head" is not protected by locks, which may cause something wrong? #8

melody97 opened this issue Aug 30, 2021 · 1 comment

Comments

@melody97
Copy link

Do I ignore something?
@wreda
Copy link
Contributor

wreda commented Sep 2, 2021

You're correct. The LibFS LRU list should be protected by a lock since the linked list methods are not thread-safe. We didn't get around to adding this since the fcache is only used when reading from SSDs. A pull request would be welcome here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wreda @melody97