Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI 3 deprecates MPI_Type_struct, changes to MPI_Type_create_struct #8

Closed
bjoo opened this issue May 20, 2019 · 2 comments
Closed

MPI 3 deprecates MPI_Type_struct, changes to MPI_Type_create_struct #8

bjoo opened this issue May 20, 2019 · 2 comments
Assignees

Comments

@bjoo
Copy link
Contributor

bjoo commented May 20, 2019

I just tried compiling QMP with OpenMPI-4.0 and it complained about MPI_Type_struct, and instructed me to change it to MPI_Type_create_struct instead. It is a straightforward substitution, apparently the function name is all that changes. We should consider changing this as a maintainance, but in a way that we can also keep the old invocation. It only occurs once in lib/mpi/QMP_mem_mpi.c as far as I can tell.

@maddyscientist
Copy link
Collaborator

Any reason why this issue isn't fixed yet? As noted above by @bjoo this breaks QMP with OpenMPI 4. MPI_type_create_struct was introduced in MPI-2. I see no reason why the reference to MPI_type_struct can't be expunged.

@bjoo bjoo self-assigned this Nov 5, 2019
@bjoo
Copy link
Contributor Author

bjoo commented Nov 6, 2019

I changed the offending MPI_type_struct to MPI_type_create_struct. I also merged master into 'devel' to eliminate that divergence, and then merged the lot into master. If master has undesirable features, I have tagged pre and post merges. Post merge is tagged as qmp2-5-2-rc

@bjoo bjoo closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants