Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #400 #401

Conversation

RS-Credentive
Copy link
Contributor

@RS-Credentive RS-Credentive commented Jul 21, 2023

Committer Notes

Addresses
#400

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@RS-Credentive
Copy link
Contributor Author

I have not updated the documentation on the website, as I believe it is automatically generated from the schema itself.

aj-stein-nist
aj-stein-nist previously approved these changes Jul 24, 2023
Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am but a bit player here, but I like it!

Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RS-Credentive Thanks for the submission. The XML changes look good.

Can you make the same changes to the JSON data types? These need to be kept in sync.

@RS-Credentive
Copy link
Contributor Author

No problem. Thanks for the heads up. I thought they were autogenerated from the metaschema, or I would have already done so.

@RS-Credentive
Copy link
Contributor Author

Updated JSON to reflect the new timezones regex you recommended.

RS-Credentive and others added 2 commits July 24, 2023 14:15
Corrected TZ pattern

Co-authored-by: David Waltermire <[email protected]>
Corrected regex for TZ in Date

Co-authored-by: David Waltermire <[email protected]>
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the additional edits.

@david-waltermire david-waltermire changed the base branch from main to develop July 29, 2023 14:30
@david-waltermire david-waltermire dismissed their stale review July 29, 2023 14:30

The base branch was changed.

@david-waltermire david-waltermire merged commit cec8027 into usnistgov:develop Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metaschema DateWithTimezoneDatatype definition allows invalid timezone values
3 participants