Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map marker shadows render weirdly when many markers close together #105

Open
rjmackay opened this issue Nov 14, 2016 · 1 comment
Open

Comments

@rjmackay
Copy link
Contributor

rjmackay commented Nov 14, 2016

screenshot 2016-11-14 15 00 49

I think part of the problem here is that we're not managing shadows separately, as leaflet does with its built in markers. I'm not 100% what the right way to do this is but its likely we need to extend L.Icon and render an additional HTML element for the shadow. This is then added to the leaflet ShadowPane, which site below the marker pane.. ensuring shadows don't overlap other markers.

We might be able to use https://github.com/hiasinho/Leaflet.vector-markers to handle much of this.

@rjmackay
Copy link
Contributor Author

rjmackay commented Dec 5, 2016

I made an attempt to fix this https://github.com/ushahidi/platform-pattern-library/tree/map-shadows

However I can't figure out the CSS-fu to generate a sensible shadow since I don't have the SVG present in the shadow layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant