Comparison results for https://github.com/SalesforceLabs/FlowEmailComposer.git

pmd7_2 took 12 seconds to run and found 33 violations

pmd7_3 took 15 seconds to run and found 33 violations

Among the 33 total comparisons:

Violation counts:

# fileName line column endLine endColumn engine ruleName severity category url message
1 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
1 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
2 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd AvoidGlobalModifier 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#avoidglobalmodifier Avoid using global modifier
2 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd AvoidGlobalModifier 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#avoidglobalmodifier Avoid using global modifier
3 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd CognitiveComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#cognitivecomplexity The class 'FlowEmailComposerCtrl' has a total cognitive complexity of 68 (highest 60), current threshold is 50
3 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd CognitiveComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#cognitivecomplexity The class 'FlowEmailComposerCtrl' has a total cognitive complexity of 68 (highest 60), current threshold is 50
4 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd StdCyclomaticComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#stdcyclomaticcomplexity The class 'FlowEmailComposerCtrl' has a Standard Cyclomatic Complexity of 8 (Highest = 21).
4 /classes/FlowEmailComposerCtrl.cls 1 21 152 2 pmd StdCyclomaticComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#stdcyclomaticcomplexity The class 'FlowEmailComposerCtrl' has a Standard Cyclomatic Complexity of 8 (Highest = 21).
5 /classes/FlowEmailComposerCtrl.cls 3 19 13 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
5 /classes/FlowEmailComposerCtrl.cls 3 19 13 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
6 /classes/FlowEmailComposerCtrl.cls 16 19 50 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
6 /classes/FlowEmailComposerCtrl.cls 16 19 50 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
7 /classes/FlowEmailComposerCtrl.cls 32 39 34 73 pmd ApexCRUDViolation 3 Security https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_security.html#apexcrudviolation Validate CRUD permission before SOQL/DML operation or enforce user mode
7 /classes/FlowEmailComposerCtrl.cls 32 39 34 73 pmd ApexCRUDViolation 3 Security https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_security.html#apexcrudviolation Validate CRUD permission before SOQL/DML operation or enforce user mode
8 /classes/FlowEmailComposerCtrl.cls 53 19 57 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
8 /classes/FlowEmailComposerCtrl.cls 53 19 57 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
9 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
9 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
10 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd CognitiveComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#cognitivecomplexity The method 'sendAnEmailMsg(String, String, String, String, String, String, String, String, String, List, List, Boolean)' has a cognitive complexity of 60, current threshold is 15
10 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd CognitiveComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#cognitivecomplexity The method 'sendAnEmailMsg(String, String, String, String, String, String, String, String, String, List, List, Boolean)' has a cognitive complexity of 60, current threshold is 15
11 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd CyclomaticComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#cyclomaticcomplexity The method 'sendAnEmailMsg(String, String, String, String, String, String, String, String, String, List, List, Boolean)' has a cyclomatic complexity of 28.
11 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd CyclomaticComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#cyclomaticcomplexity The method 'sendAnEmailMsg(String, String, String, String, String, String, String, String, String, List, List, Boolean)' has a cyclomatic complexity of 28.
12 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd ExcessiveParameterList 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#excessiveparameterlist Avoid long parameter lists.
12 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd ExcessiveParameterList 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#excessiveparameterlist Avoid long parameter lists.
13 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd NcssMethodCount 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#ncssmethodcount The method 'sendAnEmailMsg()' has an NCSS line count of 76 (limit: 40)
13 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd NcssMethodCount 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#ncssmethodcount The method 'sendAnEmailMsg()' has an NCSS line count of 76 (limit: 40)
14 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd StdCyclomaticComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#stdcyclomaticcomplexity The method 'sendAnEmailMsg' has a Standard Cyclomatic Complexity of 21.
14 /classes/FlowEmailComposerCtrl.cls 60 19 140 6 pmd StdCyclomaticComplexity 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#stdcyclomaticcomplexity The method 'sendAnEmailMsg' has a Standard Cyclomatic Complexity of 21.
15 /classes/FlowEmailComposerCtrl.cls 69 13 69 70 pmd AvoidDebugStatements 3 Performance https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_performance.html#avoiddebugstatements Avoid debug statements since they impact on performance
15 /classes/FlowEmailComposerCtrl.cls 69 13 69 70 pmd AvoidDebugStatements 3 Performance https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_performance.html#avoiddebugstatements Avoid debug statements since they impact on performance
16 /classes/FlowEmailComposerCtrl.cls 69 13 69 70 pmd DebugsShouldUseLoggingLevel 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#debugsshoulduselogginglevel Calls to System.debug should specify a logging level.
16 /classes/FlowEmailComposerCtrl.cls 69 13 69 70 pmd DebugsShouldUseLoggingLevel 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#debugsshoulduselogginglevel Calls to System.debug should specify a logging level.
17 /classes/FlowEmailComposerCtrl.cls 81 5 84 6 pmd AvoidDeeplyNestedIfStmts 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#avoiddeeplynestedifstmts Deeply nested if..then statements are hard to read
17 /classes/FlowEmailComposerCtrl.cls 81 5 84 6 pmd AvoidDeeplyNestedIfStmts 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#avoiddeeplynestedifstmts Deeply nested if..then statements are hard to read
18 /classes/FlowEmailComposerCtrl.cls 96 13 96 42 pmd AvoidDebugStatements 3 Performance https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_performance.html#avoiddebugstatements Avoid debug statements since they impact on performance
18 /classes/FlowEmailComposerCtrl.cls 96 13 96 42 pmd AvoidDebugStatements 3 Performance https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_performance.html#avoiddebugstatements Avoid debug statements since they impact on performance
19 /classes/FlowEmailComposerCtrl.cls 96 13 96 42 pmd DebugsShouldUseLoggingLevel 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#debugsshoulduselogginglevel Calls to System.debug should specify a logging level.
19 /classes/FlowEmailComposerCtrl.cls 96 13 96 42 pmd DebugsShouldUseLoggingLevel 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#debugsshoulduselogginglevel Calls to System.debug should specify a logging level.
20 /classes/FlowEmailComposerCtrl.cls 111 17 130 18 pmd AvoidDeeplyNestedIfStmts 3 Design https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_design.html#avoiddeeplynestedifstmts Deeply nested if..then statements are hard to read
20 /classes/FlowEmailComposerCtrl.cls 111 17 130 18 pmd AvoidDeeplyNestedIfStmts 3 Design https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_design.html#avoiddeeplynestedifstmts Deeply nested if..then statements are hard to read
21 /classes/FlowEmailComposerCtrl.cls 129 20 129 41 pmd ApexCRUDViolation 3 Security https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_security.html#apexcrudviolation Validate CRUD permission before SOQL/DML operation or enforce user mode
21 /classes/FlowEmailComposerCtrl.cls 129 20 129 41 pmd ApexCRUDViolation 3 Security https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_security.html#apexcrudviolation Validate CRUD permission before SOQL/DML operation or enforce user mode
22 /classes/FlowEmailComposerCtrl.cls 133 17 133 53 pmd AvoidDebugStatements 3 Performance https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_performance.html#avoiddebugstatements Avoid debug statements since they impact on performance
22 /classes/FlowEmailComposerCtrl.cls 133 17 133 53 pmd AvoidDebugStatements 3 Performance https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_performance.html#avoiddebugstatements Avoid debug statements since they impact on performance
23 /classes/FlowEmailComposerCtrl.cls 133 17 133 53 pmd DebugsShouldUseLoggingLevel 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#debugsshoulduselogginglevel Calls to System.debug should specify a logging level.
23 /classes/FlowEmailComposerCtrl.cls 133 17 133 53 pmd DebugsShouldUseLoggingLevel 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#debugsshoulduselogginglevel Calls to System.debug should specify a logging level.
24 /classes/FlowEmailComposerCtrl.cls 141 12 145 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
24 /classes/FlowEmailComposerCtrl.cls 141 12 145 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
25 /classes/FlowEmailComposerCtrl.cls 146 9 151 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
25 /classes/FlowEmailComposerCtrl.cls 146 9 151 6 pmd ApexDoc 3 Documentation https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_documentation.html#apexdoc Missing ApexDoc comment
26 /classes/FlowEmailComposerCtrlTest.cls 12 23 18 6 pmd ApexUnitTestMethodShouldHaveIsTestAnnotation 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexunittestmethodshouldhaveistestannotation Apex test methods should have @isTest annotation.
26 /classes/FlowEmailComposerCtrlTest.cls 12 23 18 6 pmd ApexUnitTestMethodShouldHaveIsTestAnnotation 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexunittestmethodshouldhaveistestannotation Apex test methods should have @isTest annotation.
27 /classes/FlowEmailComposerCtrlTest.cls 16 9 16 52 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'system.assert' should have 2 parameters.
27 /classes/FlowEmailComposerCtrlTest.cls 16 9 16 52 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'system.assert' should have 2 parameters.
28 /classes/FlowEmailComposerCtrlTest.cls 17 9 17 125 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'system.assert' should have 2 parameters.
28 /classes/FlowEmailComposerCtrlTest.cls 17 9 17 125 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'system.assert' should have 2 parameters.
29 /classes/FlowEmailComposerCtrlTest.cls 19 23 25 6 pmd ApexUnitTestMethodShouldHaveIsTestAnnotation 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexunittestmethodshouldhaveistestannotation Apex test methods should have @isTest annotation.
29 /classes/FlowEmailComposerCtrlTest.cls 19 23 25 6 pmd ApexUnitTestMethodShouldHaveIsTestAnnotation 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexunittestmethodshouldhaveistestannotation Apex test methods should have @isTest annotation.
30 /classes/FlowEmailComposerCtrlTest.cls 21 9 21 46 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'System.assertEquals' should have 3 parameters.
30 /classes/FlowEmailComposerCtrlTest.cls 21 9 21 46 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'System.assertEquals' should have 3 parameters.
31 /classes/FlowEmailComposerCtrlTest.cls 24 9 24 105 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'System.assertEquals' should have 3 parameters.
31 /classes/FlowEmailComposerCtrlTest.cls 24 9 24 105 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'System.assertEquals' should have 3 parameters.
32 /classes/FlowEmailComposerCtrlTest.cls 27 23 43 6 pmd ApexUnitTestMethodShouldHaveIsTestAnnotation 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexunittestmethodshouldhaveistestannotation Apex test methods should have @isTest annotation.
32 /classes/FlowEmailComposerCtrlTest.cls 27 23 43 6 pmd ApexUnitTestMethodShouldHaveIsTestAnnotation 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexunittestmethodshouldhaveistestannotation Apex test methods should have @isTest annotation.
33 /classes/FlowEmailComposerCtrlTest.cls 36 13 38 63 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.2.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'system.assert' should have 2 parameters.
33 /classes/FlowEmailComposerCtrlTest.cls 36 13 38 63 pmd ApexAssertionsShouldIncludeMessage 3 Best Practices https://docs.pmd-code.org/pmd-doc-7.3.0/pmd_rules_apex_bestpractices.html#apexassertionsshouldincludemessage 'system.assert' should have 2 parameters.