Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using tags among all users #3985

Closed
non9mer opened this issue Oct 3, 2024 · 2 comments
Closed

using tags among all users #3985

non9mer opened this issue Oct 3, 2024 · 2 comments
Labels
enhancement New feature or request Stale

Comments

@non9mer
Copy link

non9mer commented Oct 3, 2024

Describe the solution you'd like

HELLO!
It would be great to be able to see and use tags in workspace that were created by another user.
So, let's say another user created a note in the workspace section, creating new tags for it, but the current implementation does not allow these tags to be shared between other users, and this seems very useful.

Best wishes!

Type of feature

User Interface (UI)

Additional context

I'm trying to make it so that when new tags are created, they are shared among all users, appearing in the right column, under the TAGS section.

@non9mer non9mer added the enhancement New feature or request label Oct 3, 2024
@github-actions github-actions bot added the Stale label Oct 17, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@RoccoSmit
Copy link
Contributor

@boojack, I'd like to implement this.

The 2 ways I was thinking about are:

  1. Create a useTagsdataStore that leverages useMemoMetadataStore. useMemoMetadataStore would get a all the metadata info including tags (private, protected and public) for the user and useTagsdataStore would make another call and get all user's protected and public tags and merge the 2 lists of tags together.

This approach has some shortcoming in that it will retrieve the user's public and protected tags 2 times, but it is a smaller change in the code and uses existing mechanisms.

  1. Add another filter list that will be mapped to or logical operators in the .sql file queries. This way the db query can get all memos that have a creatorId of x or protected and public visibility all in a single query.

This approach is more involved as it will require changes across FE, server and db store files for all 3 db types.

Thoughts?

@non9mer
Copy link
Author

non9mer commented Dec 4, 2024

up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants