Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider non-planar edge reconnection to skeletonized artifact #116

Open
anastassiavybornova opened this issue Jul 26, 2024 · 4 comments
Assignees

Comments

@anastassiavybornova
Copy link
Collaborator

continue work on typology-multiples notebook on n-clusters branch.

we need to reconsider how exactly identify the edges AND their nodes which need to get reconnected to the skeleton; and whether (not implemented yet) some of these edges should be dropped entirely under certain conditions (smth like "connected to skeleton boundary on one end, and leading into the artifact cluster on the other end", eg here: https://www.openstreetmap.org/search?lat=50.6463&lon=5.4712#map=15/50.6463/5.4712 )

the current implementation solves some cases (eg below) but "over"connects others.

image

@anastassiavybornova
Copy link
Collaborator Author

@martinfleis i think we can close this one?

@martinfleis
Copy link
Contributor

Did we ever reconsidered it? :)

@anastassiavybornova
Copy link
Collaborator Author

i don't think we came up with a solution, but i do have a vague memory of deciding not to look further into non-planar edge connection? and accept the fact that non-planar edges are cut off at artifact boundaries?

we can also label this as feature request for future work, instead of closing, but curious to hear what the current way of reconnecting non-planar edges is (if i'm mistaken in what i recall)

@martinfleis
Copy link
Contributor

and accept the fact that non-planar edges are cut off at artifact boundaries?

They are not. But they maybe should be.

I would not close this issue but I remember it being a little annoying occasionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants