Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we match the version? #55

Open
daeho-ro opened this issue Jan 19, 2025 · 1 comment
Open

How can we match the version? #55

daeho-ro opened this issue Jan 19, 2025 · 1 comment
Labels
packaging Packaging, package managers and/or repositories

Comments

@daeho-ro
Copy link

Summary

Hello, this is a HomeBrew maintainer and want to ask a question how we can check the version.

For the version 25.1.0, (based on Cargo.toml file)

> hx --version 
evil-helix 25.1

and also GitHub tag for the source is release-20250104.

We are trying to add the test case based on tag or toml but it seems that it is not possible.
Are these can be improved or any alternative ways?

Thanks,

Releated PR:

Reproduction Steps

I tried this:

  1. hx

I expected this to happen:

Instead, this happened:

Helix log

~/.cache/helix/helix.log
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

macOS

Terminal Emulator

none

Installation Method

source

Helix Version

evil-helix 25.1

@usagi-flow
Copy link
Owner

Hey there, thank you for working on a Homebrew package, and sorry for replying just now.

At the moment, hx --version indeed includes the tagged commit hash and the upstream version. It currently doesn't include the tag name.

evil-helix: evil-helix (8d82e9cc, helix 25.1)
Upstream: helix 25.1

I would be open to adjusting the version format (although I remember getting the tag name wasn't trivial), but I also see you managed to find a solution and get the Homebrew checks green again.

Feel free to let me know if there is still something to be done.

@usagi-flow usagi-flow added the packaging Packaging, package managers and/or repositories label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Packaging, package managers and/or repositories
Projects
None yet
Development

No branches or pull requests

2 participants