Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetching breaks when variables change #501

Closed
narinluangrath opened this issue Jan 10, 2020 · 4 comments · Fixed by #503
Closed

fetching breaks when variables change #501

narinluangrath opened this issue Jan 10, 2020 · 4 comments · Fixed by #503
Labels
bug 🐛 Oh no! A bug or unintented behaviour.

Comments

@narinluangrath
Copy link
Contributor

Describe the bug
Changing variables in useQuery causes fetching to get stuck on true, even when data has finished requerying.

Steps to reproduce
Steps to reproduce the behavior:
https://codesandbox.io/s/urql-fetching-bug-8xond

  1. Change the input
  2. Change it back what it originally was

Expected behavior
fetching goes back to false after data requeries (or gets it from cache).

Actual behavior
fetching stays at true

@narinluangrath narinluangrath added the bug 🐛 Oh no! A bug or unintented behaviour. label Jan 10, 2020
@narinluangrath
Copy link
Contributor Author

The data field seems broken too. Probably just missing dependency in useMemo or something.

@kitten
Copy link
Member

kitten commented Jan 10, 2020

Interesting! I can confirm that this is happening and I’ll look into it

@kitten
Copy link
Member

kitten commented Jan 11, 2020

A fix for this is ready and it does cause the correct behaviour again in the CodeSandbox 🙌

@kitten
Copy link
Member

kitten commented Jan 11, 2020

The fix in #503 is now published with v1.8.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Oh no! A bug or unintented behaviour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants