Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings are broken after recent changes #2662

Closed
3 tasks done
devunt opened this issue Sep 2, 2022 · 3 comments · Fixed by #2663
Closed
3 tasks done

Typings are broken after recent changes #2662

devunt opened this issue Sep 2, 2022 · 3 comments · Fixed by #2663
Labels
needs more info ✋ A question or report that needs more info to be addressable

Comments

@devunt
Copy link

devunt commented Sep 2, 2022

Describe the bug

Some of urql typings are broken after #2607 was introduced.

To be precise, it is broken in next three files.

Reproduction

It is a typing issue

Urql version

@urql/core 3.0.2
urql 3.0.1

Validations

  • I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • Read the docs.
  • Follow our Code of Conduct
@JoviDeCroock
Copy link
Collaborator

JoviDeCroock commented Sep 2, 2022

Hey,

Mind pointing out what is wrong with it, TypeScript in Strict mode isn't having any issues 😅 we ask for a reproduction or at the very least the error the error in question.

You are pointing at three files and telling us it's a typing issue but I can't really go off that as it's succeeding for me.

EDIT: I think I understand what you mean now but hard for other external folks to jump on this 😅

@JoviDeCroock JoviDeCroock added the needs more info ✋ A question or report that needs more info to be addressable label Sep 2, 2022
@devunt
Copy link
Author

devunt commented Sep 2, 2022

@JoviDeCroock
Apologize for providing not enough information at the first place 😢 Glad you understood it though.

@JoviDeCroock
Copy link
Collaborator

No worries we got there 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info ✋ A question or report that needs more info to be addressable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants