Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hpxml requirement for number_of_residential_units #192

Closed
vtnate opened this issue Jan 22, 2024 · 2 comments
Closed

Remove hpxml requirement for number_of_residential_units #192

vtnate opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@vtnate
Copy link
Collaborator

vtnate commented Jan 22, 2024

number_of_residential_units is required in the geojson file, possibly starting in HPXML v1.7.0. The check for this field doesn't need to exist as this information should be, and is, contained within the HPXML file itself. AFAIK there isn't any problem removing this check from the code.

@vtnate vtnate added the bug Something isn't working label Jan 22, 2024
@joseph-robertson
Copy link
Collaborator

Hi @vtnate. Are you able to point explicitly to the check you're referring to in this issue?

@vtnate
Copy link
Collaborator Author

vtnate commented Jun 24, 2024

Hmmm, good question. No, I can't find it now. That seems like a good indicator that this is a stale issue! I'll close and if it's a problem in the future we can sort it out then.

@vtnate vtnate closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants