Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chromedriver-helper to Gemfile? #1

Open
nicedawg opened this issue Jul 24, 2018 · 1 comment
Open

Add chromedriver-helper to Gemfile? #1

nicedawg opened this issue Jul 24, 2018 · 1 comment

Comments

@nicedawg
Copy link

Thank you so much for sharing this project! I too am interested in having this fixed.

(I'd like headless chrome to work well with the acceptInsecureCerts to avoid having to use sudo to install puffing-billy's dynamic CA cert every time I run my feature specs on my Mac. Even worse is asking my co-workers to do it. haha.) Maybe I misunderstand, but I think if acceptInsecureCerts + headless chrome worked well, then we wouldn't need to do that?

Anyway, I referenced your project in igrigorik/em-http-request#320, hoping it might help narrow down the issue. But then I realized I didn't try your repro project yet!

When I tried to run it, I got "could not connect to chromedriver" errors. Took me a minute to realize I needed to have chromedriver setup on my own. I just added the chromedriver-helper gem to your Gemfile, re-ran bundle install and was on my way. But maybe somebody else who's interested in trying out the reproduction might not know to do that, so I thought I'd mention it in case you saw fit to add it yourself.

Also, FWIW - I too see the "Fail/Pass" as described, even when using the most recent Chromedriver/Chrome combination. (ChromeDriver 2.40.565386 (45a059dc425e08165f9a10324bd1380cc13ca363), and Chrome 67.0.3396.99 on MacOS 10.13.4.

Thanks again!

@urbanautomaton
Copy link
Owner

urbanautomaton commented Aug 2, 2018

Maybe I misunderstand, but I think if acceptInsecureCerts + headless chrome worked well, then we wouldn't need to do that?

Yep, that's right. 👍

FWIW, in our project we've switched from puffing-billy to using mitmproxy (specifically, its mitmdump headless version via the Python API). The downsides are it's another process to manage, and we have slightly less flexible response stubbing; the upsides are, it works fine with acceptInsecureCerts. For our needs that's fine, but if you're doing lots of messing about with remote requests (e.g. varying their response bodies), it might not be a great option.

Thanks for the chromedriver-helper tip, I wasn't aware of that, will add it shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants