Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook from 6.0 to 6.1 #128

Closed
5 of 7 tasks
ghost opened this issue Nov 20, 2020 · 2 comments · Fixed by #138
Closed
5 of 7 tasks

Upgrade Storybook from 6.0 to 6.1 #128

ghost opened this issue Nov 20, 2020 · 2 comments · Fixed by #138
Labels
chore Technical debt or code refactoring

Comments

@ghost
Copy link

ghost commented Nov 20, 2020

I've tried upgrading to 6.1.1 6.1.10, however, there are too many issues/bugs that still have not been reported and fixed.

Some issues observed (tick if observed fix):

  • custom logo disappears
  • addon/backgrounds is buggy esp. w/ addon/docs:
    • background colour doesn't change
    • sometimes the page content disappears when the background tool is clicked
    • grid feature no longer works
  • code fenced sass/scss code is monochromatic (not a deal breaker as we can take of it via customisation)
  • Canvas elem with toolbar no longer displays button to open canvas in new tab if story is created within MDX doc Not specific to this version (needs investigation).

Two positive notes are that search and navigation work much faster and single story hoisting is good.

We need to revisit this upgrade in the next few releases. We might even need to consider reporting bugs to the Storybook working group ourselves.

@ghost ghost added the chore Technical debt or code refactoring label Nov 20, 2020
@ghost ghost pinned this issue Nov 20, 2020
@Bcrunk
Copy link
Contributor

Bcrunk commented Nov 23, 2020

@uqmchu , just confirming that it is the storybook update that has issues, when those issues are fixed we will move forward with updating?

Its not issues with our system that need to be fixed at this stage.

@ghost
Copy link
Author

ghost commented Dec 8, 2020

The upgrade seems good to go. The only thing is that the scss syntax in the code fences are coming through with black text only. Changing the code fence syntax declaration to css seems to fix it but this is not ideal. As we plan to customise the code example style anyway, this is not a big deal.

@ghost ghost self-assigned this Dec 8, 2020
@ghost ghost mentioned this issue Dec 8, 2020
@ghost ghost closed this as completed in #138 Dec 16, 2020
@ghost ghost unpinned this issue Feb 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Technical debt or code refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant