Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipCaller is not copied when calling With and Ctx on SugaredLogger - results in panic #62

Closed
piotrklosowski opened this issue Jul 5, 2022 · 1 comment
Closed

skipCaller is not copied when calling With and Ctx on SugaredLogger - results in panic #62

piotrklosowski opened this issue Jul 5, 2022 · 1 comment

Comments

@piotrklosowski
Copy link

When first calling With function on SugaredLogger and then Ctx, any further occurring logging function calls result in panic as they require skipCaller to be not nil. skipCaller is not copied/updated when calling With function. Please confirm if it is a bug

Relevant code link below:

opentelemetry-go-extra/otelzap/otelzap.go

Line 379 in c155edf

func (s *SugaredLogger) With(args ...interface{}) *SugaredLogger {

@vmihailenco
Copy link
Member

Yes, looks like a bug. Could you send a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmihailenco @piotrklosowski