Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added QueryBuilder interface for SelectQuery,UpdateQuery,DeleteQuery #499

Merged
merged 4 commits into from
Mar 26, 2022
Merged

added QueryBuilder interface for SelectQuery,UpdateQuery,DeleteQuery #499

merged 4 commits into from
Mar 26, 2022

Conversation

derkan
Copy link
Contributor

@derkan derkan commented Mar 26, 2022

closes #497

@vmihailenco
Copy link
Member

Could you also add a test to internal/dbtest/query_test.go?

vmihailenco
vmihailenco reviewed Mar 26, 2022
View reviewed changes
query_delete.go Outdated Show resolved Hide resolved
vmihailenco
vmihailenco reviewed Mar 26, 2022
View reviewed changes
query_base.go Outdated Show resolved Hide resolved
@vmihailenco
Copy link
Member

Looks good - thanks 👍

@vmihailenco vmihailenco merged commit 59fef48 into uptrace:master Mar 26, 2022
@frederikhors
Copy link

Is there any docs for this? @vmihailenco can we merge docs in this repo? So anyone can update the docs too?

@frederikhors
Copy link

I think a feature without docs == no feature at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmihailenco vmihailenco vmihailenco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting Where condition of SelectQuery,UpdateQuery centrally
3 participants
@derkan @vmihailenco @frederikhors