Mysql compatibility fixes #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for the PR. I am going to merge this as is and work in a separate PR on customizing type handling in dialects.
A simple but somewhat messy way is to move
I don't like it and going to try to find a better way. |
vmihailenco
pushed a commit
that referenced
this pull request
Oct 22, 2021
This was referenced Oct 22, 2021
|
Wow, thanks for the speedy merge and follow up @vmihailenco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL uses
On("DUPLICATE KEY UPDATE")vs PostgreSQL'sOn("CONFLICT DO UPDATE")and also has a slightly different format forVALUES.I also included an example of a change I needed to make to support binary data in MySQL. I understand this change cannot be merged as-is and I would appreciate some guidance on how to make it correctly.