From c60f37af9e4f7e63af297c69aad653e5e30ee8c0 Mon Sep 17 00:00:00 2001 From: Benjamin Quorning Date: Mon, 28 Oct 2024 19:37:50 +0100 Subject: [PATCH] Stop using the Cane gem It doesn't work with Ruby 3.1+, and in 2018 its maintainer wrote that users should consider switching to RuboCop. --- .cane | 2 -- Rakefile | 8 +------- TESTING.md | 3 --- docker-api.gemspec | 1 - 4 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 .cane diff --git a/.cane b/.cane deleted file mode 100644 index 7b5cd88b..00000000 --- a/.cane +++ /dev/null @@ -1,2 +0,0 @@ ---abc-max 30 ---style-measure 120 diff --git a/Rakefile b/Rakefile index 5bf649f0..63645126 100644 --- a/Rakefile +++ b/Rakefile @@ -4,20 +4,14 @@ ENV['PATH'] = "/opt/docker/:#{ENV['PATH']}" if ENV['CI'] == 'true' require 'docker' require 'rspec/core/rake_task' -require 'cane/rake_task' - desc 'Run the full test suite from scratch' -task :default => [:unpack, :rspec, :quality] +task :default => [:unpack, :rspec] RSpec::Core::RakeTask.new do |t| t.pattern = 'spec/**/*_spec.rb' end -Cane::RakeTask.new(:quality) do |cane| - cane.canefile = '.cane' -end - desc 'Download the necessary base images' task :unpack do %w( swipely/base registry busybox:uclibc tianon/true debian:stable ).each do |image| diff --git a/TESTING.md b/TESTING.md index 4c5c7f17..52e3dc98 100644 --- a/TESTING.md +++ b/TESTING.md @@ -33,9 +33,6 @@ This repository comes with five Rake commands to assist in your testing of the c ## `rake rspec` This command will run Rspec tests normally on your local system. You must have all the required base images pulled. -## `rake quality` -This command runs a code quality threshold checker to hinder bad code. - ## `rake unpack` Pulls down all the required base images for testing. diff --git a/docker-api.gemspec b/docker-api.gemspec index 0d6a70a7..fd62c154 100644 --- a/docker-api.gemspec +++ b/docker-api.gemspec @@ -15,7 +15,6 @@ Gem::Specification.new do |gem| gem.add_development_dependency 'rake' gem.add_development_dependency 'rspec', '~> 3.0' gem.add_development_dependency 'rspec-its' - gem.add_development_dependency 'cane' gem.add_development_dependency 'pry' gem.add_development_dependency 'single_cov' gem.add_development_dependency 'webmock'