Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom plan modifier for groups field in the MQ User resource #283

Closed
wants to merge 1 commit into from

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Feb 6, 2025

Description

Introduced a custom plan modifier (listSortModifier) to ensure the groups attribute in the MQ User resource is always sorted alphabetically during the plan phase.
This modifier sorts the groups list and prevents unnecessary diffs between plan and state.

Fixes crossplane-contrib/provider-upjet-aws#1657

Copy link

github-actions bot commented Feb 6, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 6, 2025

Closed in favor of #284

@turkenf turkenf closed this Feb 6, 2025
@turkenf turkenf deleted the ticket-797 branch February 6, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant