Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker username and password to secrets workflow #222

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

turkenf
Copy link
Contributor

@turkenf turkenf commented Sep 30, 2024

Description of your changes

In this PR:

  • Adds docker username and password to secrets workflow
  • Adds registry: xpkg.upbound.io parameter to docker login step.
  • Adds token to Upload Trivy Scan Results To GitHub Security Tab step

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested turkenf/provider-opentofu and turkenf/provider-family-gcp-beta. Only the Upload Trivy Scan Results To GitHub Security Tab step could not be tested, as it is available for the organization.

@turkenf turkenf marked this pull request as ready for review October 1, 2024 10:16
@turkenf turkenf merged commit 932f24b into upbound:main Oct 1, 2024
6 checks passed
@turkenf turkenf deleted the add-secrets branch October 1, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants