Performance tool can accept test MRs via URLs #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piotr1215
force-pushed
the
perf-test-url-input
branch
3 times, most recently
from
821171e to
2cd9c8e
Compare
Managed resources used for performance testing are read from disk and passed as arguments to the CLI. This commit introduces changes to the CLI so that test MRs can now be passed via URLs. This change is needed to add more flexible test scenarios for the performance CI pipeline.
Piotr1215
force-pushed
the
perf-test-url-input
branch
from
2cd9c8e to
bf5fd9b
Compare
sergenyalcin
approved these changes
Aug 26, 2023
cmd/perf/internal/managed/managed.go
Outdated
| return nil, errors.Wrap(err, "cannot fetch URL") | ||
| } | ||
| defer func() { | ||
| _ = resp.Body.Close() |
There was a problem hiding this comment.
nit: What about handling this error?
There was a problem hiding this comment.
Thank you for the suggestion @sergenyalcin , i've handled the error.
Piotr1215
force-pushed
the
perf-test-url-input
branch
from
2ac9129 to
cf073f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Managed resources used for performance testing are read from disk and passed as arguments to the CLI. This commit introduces changes to the CLI so that test MRs can now be passed via URLs.
This change is needed to add more flexible test scenarios for the performance CI pipeline.
Fixes https://github.com/upbound/team-extensions/issues/177
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Locally running the tool with URL MRs