You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is probably the least important issue but figured we can discuss it anyway.
All the current stable versions of node and browsers support promises and bluebird is not a dependency that libraries should ship with if it can be avoided.
the codebase itself could really benefit from cleanup and a switch to native promises and async/await.
I don't see this adding much value other than decreasing the likelihood of silly errors like #62 and general code legibility (promises with callbacks tend to be less legible in most circumstances than the equivalent async/await).
P.S. I am aware that not ALL promise usages should be transferred to async/await, especially for concurrency but most of the functions tend to be step by step inside anyway.
The text was updated successfully, but these errors were encountered:
This is probably the least important issue but figured we can discuss it anyway.
All the current stable versions of node and browsers support promises and bluebird is not a dependency that libraries should ship with if it can be avoided.
the codebase itself could really benefit from cleanup and a switch to native promises and
async/await
.I don't see this adding much value other than decreasing the likelihood of silly errors like #62 and general code legibility (promises with callbacks tend to be less legible in most circumstances than the equivalent async/await).
P.S. I am aware that not ALL promise usages should be transferred to async/await, especially for concurrency but most of the functions tend to be step by step inside anyway.
The text was updated successfully, but these errors were encountered: