Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration by environment #33

Open
pola88 opened this issue Jan 11, 2019 · 3 comments
Open

Configuration by environment #33

pola88 opened this issue Jan 11, 2019 · 3 comments

Comments

@pola88
Copy link

pola88 commented Jan 11, 2019

It would be great to set different config for development test production. What do you think about this?

@weekens
Copy link
Contributor

weekens commented Jan 11, 2019

Yeah, looks like a nice enhancement.

@weekens
Copy link
Contributor

weekens commented Jan 11, 2019

Actually, this functionality can be easily implemented using the following code:

let actorSystem = actors({
  config: `./actors-${process.env.COMEDY_MODE || 'prod'}.json`
});

I don't think we need something more complex than the above.

@pct-cclausen
Copy link

I think an issue with this is that it seems not straightforward in typescript to access the global actor system configuration, I have to do this:

(system as any).options.config

to access the global config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants