Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Initial focus on Page #6651

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): fixes #6650

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Previously, the first focusable child was focused on Page, even if the Page itself was focusable.

What is the new behavior?

Now the Page can be focused itself, which matches UWP. In addition, on initial focus we avoid opening the InputPane in case the initial focused element is a TextBox.

PR Checklist

Please check if your PR fulfills the following requirements:

@MartinZikmund MartinZikmund requested a review from a team August 3, 2021 15:09
@gitpod-io
Copy link

gitpod-io bot commented Aug 3, 2021

@MartinZikmund MartinZikmund marked this pull request as draft August 3, 2021 15:10
@MartinZikmund MartinZikmund force-pushed the dev/mazi/initial-focus branch from 86dd200 to 39790b8 Compare August 3, 2021 15:11
@MartinZikmund MartinZikmund self-assigned this Aug 13, 2021
@MartinZikmund MartinZikmund marked this pull request as ready for review September 7, 2021 18:02
@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Sep 10, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Previously, the first focusable child was focused on Page, even if the Page itself was focusable. Now the Page can be focused itself, which matches UWP. In addition, on initial focus we avoid opening the InputPane in case the initial focused element is a TextBox.
@mergify mergify bot merged commit 24c16cc into unoplatform:master Sep 17, 2021
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/3.10

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2021

Command backport release/stable/3.10: success

Backports have been created

jeromelaban added a commit that referenced this pull request Sep 21, 2021
….10/pr-6651

fix: Initial focus on Page (backport #6651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial focus on page load opens software keyboard
5 participants