Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skia] DataGrid VerticalScrollBar inverted, slow, and jerky when scrolling with mouse #9068

Closed
Tracked by #8597
bstrother1 opened this issue Jun 16, 2022 · 4 comments
Closed
Tracked by #8597

[Skia] DataGrid VerticalScrollBar inverted, slow, and jerky when scrolling with mouse #9068

bstrother1 opened this issue Jun 16, 2022 · 4 comments
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/scrollviewer ⏬ Categorizes an issue or PR as relevant to ScrollViewer area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/windows-community-toolkit 🎚️ Categorizes an issue or PR as relevant to the Windows Community Toolkit difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) project/pointers 🖱️ Categorizes an issue or PR as relevant to mouse/touch/pen pointers triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@bstrother1
Copy link

Current behavior

In WPF the VerticalScrollBar is inverted (up is down and down is up), slow, and jerks when using a mouse. UWP does not do this. Attached project is reused from another ticket.

DataGridResizeIncorrect.zip

Expected behavior

VerticalScrollBar to function similarly to UWP's implementation.

How to reproduce it (as minimally and precisely as possible)

-Make Project
-Add Datagrid
-Enable VerticalScrollBar
-Try scrolling with mouse

Workaround

n/a

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia

NuGet package version(s)

WPF:
PackageReference Include="Uno.UI.Skia.Wpf" Version="4.1.8"
PackageReference Include="Uno.UI.RemoteControl" Version="4.1.8" Condition="'$(Configuration)'=='Debug'" />
PackageReference Include="Uno.UI.Adapter.Microsoft.Extensions.Logging" Version="4.1.8"
PackageReference Include="Uno.Microsoft.Toolkit" Version="7.1.11"
PackageReference Include="Uno.Microsoft.Toolkit.Uwp" Version="7.1.11"
PackageReference Include="Uno.Microsoft.Toolkit.Uwp.UI" Version="7.1.11"
PackageReference Include="Uno.Microsoft.Toolkit.Uwp.UI.Controls" Version="7.1.11"
PackageReference Include="Uno.Microsoft.Toolkit.Uwp.UI.Controls.DataGrid" Version="7.1.11"
PackageReference Include="Uno.Microsoft.Toolkit.Uwp.UI.Controls.Layout" Version="7.1.11"

WPF Host:
PackageReference Include="Uno.UI.Skia.Wpf" Version="4.1.8"
PackageReference Include="Uno.UI.RemoteControl" Version="4.1.8" Condition="'$(Configuration)'=='Debug'"
PackageReference Include="Uno.UI.Adapter.Microsoft.Extensions.Logging" Version="4.1.8"

Affected platforms

Skia (WPF)

IDE

Visual Studio 2022

IDE version

17.0.4

Relevant plugins

No response

Anything else we need to know?

Still occurs with latest dev release.
@bstrother1 bstrother1 added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Jun 16, 2022
@jeromelaban jeromelaban added the project/pointers 🖱️ Categorizes an issue or PR as relevant to mouse/touch/pen pointers label Jun 16, 2022
@jeromelaban jeromelaban changed the title [WPF] Datagrid VerticalScrollBar inverted, slow, and jerky when scrolling with mouse [Skia] Datagrid VerticalScrollBar inverted, slow, and jerky when scrolling with mouse Jun 16, 2022
@jeromelaban jeromelaban added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jun 16, 2022
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Dec 2, 2022
@heulendoch
Copy link

Having the same issue. The required rendering time of a datagrid in wasm or anroid is really high.

@jeromelaban jeromelaban added the area/performance 📈 Categorizes an issue or PR as relevant to performance label Jan 26, 2023
@jeromelaban jeromelaban mentioned this issue Jan 26, 2023
Open
71 tasks
@MartinZikmund MartinZikmund changed the title [Skia] Datagrid VerticalScrollBar inverted, slow, and jerky when scrolling with mouse [Skia] DataGrid VerticalScrollBar inverted, slow, and jerky when scrolling with mouse Jul 31, 2023
@MartinZikmund MartinZikmund added area/windows-community-toolkit 🎚️ Categorizes an issue or PR as relevant to the Windows Community Toolkit area/scrollviewer ⏬ Categorizes an issue or PR as relevant to ScrollViewer project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 31, 2023
@lld1995
Copy link

lld1995 commented Nov 1, 2023 •
edited
Loading

What a serious problem....But i think it can rewrite Template to avoid this problem.
Do it like https://github.com/CommunityToolkit/WindowsCommunityToolkit/blob/main/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/DataGrid.xaml

@ramezgerges
Copy link
Contributor

Is this still reproducing on 5x? I couldn't get the repro to work for some reason but trying with a new uno app, everything seems to be working. Scrolling is not inverted. It seems to be a little bit jittery when scrolled quickly on WASM, but that's it. @bstrother1 can you please try again and update the issue?

@ramezgerges ramezgerges added the triage/needs-information Indicates an issue needs more information in order to work on it. label Dec 1, 2023
@jeromelaban
Copy link
Member

Thanks for the update, closing for now. If there's any update on this issue, we'll give it another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/scrollviewer ⏬ Categorizes an issue or PR as relevant to ScrollViewer area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/windows-community-toolkit 🎚️ Categorizes an issue or PR as relevant to the Windows Community Toolkit difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) project/pointers 🖱️ Categorizes an issue or PR as relevant to mouse/touch/pen pointers triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@MartinZikmund @jeromelaban @heulendoch @lld1995 @bstrother1 @ramezgerges