Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageDiff step is only validating Uno.UI package #6890

Open
jeromelaban opened this issue Aug 27, 2021 · 5 comments
Open

PackageDiff step is only validating Uno.UI package #6890

jeromelaban opened this issue Aug 27, 2021 · 5 comments
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@jeromelaban
Copy link
Member

What would you like to be added:

Additional validation for packages like GTK/WPF/Wasm runtime support.

Why is this needed:

Avoid breaking changes.
@jeromelaban jeromelaban added kind/enhancement New feature or request area/build Categorizes an issue or PR as relevant to build infrastructure project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 27, 2021
@Youssef1313
Copy link
Member

@jeromelaban Does PackageDiff catches changes like sealing a class or changing the static-ness of a class?
If not, that would be a good addition as well.

@jeromelaban
Copy link
Member Author

jeromelaban commented Aug 28, 2021 •
edited by unfurl-links bot
Loading

I don't think it does: https://github.com/unoplatform/Uno.PackageDiff

GitHub
A command line tool that compares two versions of a NuGet package and provides public API differences - GitHub - unoplatform/Uno.PackageDiff: A command line tool that compares two versions of a NuG...

@Youssef1313
Copy link
Member

@jeromelaban Do you think it's worth opening an issue to track that? If yes, would it be preferred to track it in this repo or in Uno.PackageDiff repo?

@jeromelaban
Copy link
Member Author

@Youssef1313 the other repository is fine, and yes we should track it. Thanks!

@Youssef1313
Copy link
Member

Thanks. ▶️ unoplatform/Uno.PackageDiff#14

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinZikmund @jeromelaban @Youssef1313