Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm] Satellite assemblies are not properly published #11043

Closed
paulovila opened this issue Jan 24, 2023 · 4 comments · Fixed by unoplatform/Uno.Wasm.Bootstrap#665
Closed

[Wasm] Satellite assemblies are not properly published #11043

paulovila opened this issue Jan 24, 2023 · 4 comments · Fixed by unoplatform/Uno.Wasm.Bootstrap#665
Assignees
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/resources 🈷️ Categorizes an issue or PR as relevant to resources and localization (Resources, Assets,...)

Comments

@paulovila
Copy link

paulovila commented Jan 24, 2023

Current behavior

In WASM, the ResourceManager.GetString uses the CultureInfo as parameter, but fails to recognise the culture passed
image

Expected behavior

It should return the culture passed regardless of the supported languages of the browser.

How to reproduce it (as minimally and precisely as possible)

see example in https://github.com/paulovila/UnoLocalization/blob/master/App9/App9.Shared/MainPage.xaml.cs
UnoLocalization-master.zip

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@paulovila paulovila added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Jan 24, 2023
@jeromelaban jeromelaban added project/resources 🈷️ Categorizes an issue or PR as relevant to resources and localization (Resources, Assets,...) and removed triage/untriaged Indicates an issue requires triaging or verification labels Jan 24, 2023
@jeromelaban
Copy link
Member

Localization at this time is best supported using resw, not embedded assembly resources. Are you able to use resw instead?

@paulovila
Copy link
Author

The netstandard2 project is also referenced from WPF, therefore Windows.ApplicationModel.Resources.ResourceLoader .GetForViewIndependentUse().GetString(resource); can't be used.
Is it possible to re-implement System.Resources.ResourceManager.GetString , or where's the source code of this?

@jeromelaban jeromelaban changed the title CultureInfo ignored in ResourceManager.GetString [Wasm] Satellite assemblies are not properly published Jan 25, 2023
@jeromelaban
Copy link
Member

Thanks. This issue is related to satellite assemblies publishing in the uno bootstrapper. Reimplementing it on your side is one option, but not necessarily the best one either.

@darenm
Copy link
Contributor

darenm commented Jan 25, 2023

@jeromelaban Sounds like this is a non-trivial issue to address on either side. Are there any plans to address this in Uno?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/resources 🈷️ Categorizes an issue or PR as relevant to resources and localization (Resources, Assets,...)
Projects
None yet
3 participants