Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The PWA manifest link should be at the root #872

Closed
jeromelaban opened this issue Jul 11, 2024 · 1 comment
Closed

The PWA manifest link should be at the root #872

jeromelaban opened this issue Jul 11, 2024 · 1 comment
Assignees
@ebariche

Comments

@jeromelaban
Copy link
Member

GenerateIndexHtml invalidates the modifications done by GeneratePWAContent:

Possible solution:

html = html.Replace($"\"./", $"\"{WebAppBasePath}{_remoteBasePackagePath}/");
html = html.Replace($"\"{WebAppBasePath}{_remoteBasePackagePath}/{Path.GetFileName(PWAManifestFile)}", $"{WebAppBasePath}{Path.GetFileName(PWAManifestFile)}");

The PWA manifest must always be at the root.
@jeromelaban jeromelaban mentioned this issue Jul 12, 2024
Closed
1 task
@jeromelaban
Copy link
Member Author

Fixed in #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebariche ebariche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromelaban @ebariche