Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow mocking subpaths of proxy #46

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix: allow mocking subpaths of proxy #46

merged 1 commit into from
Aug 5, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 5, 2022

nuxt/nuxt#13238, nuxt/nuxt#14160

When something that has been aliased to proxy-cjs is accessed with a subpath, it falls back to the next valid subpath, which will never succeed: import (unenv/runtime/* => unenv/runtime/mock/proxy-cjs/.cjs).

@danielroe danielroe requested a review from pi0 August 5, 2022 14:30
@danielroe danielroe self-assigned this Aug 5, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the workaround!

@pi0 pi0 merged commit 70efe37 into main Aug 5, 2022
@pi0 pi0 deleted the fix/proxy-subpaths branch August 5, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants